Merged
Conversation
mikooomich
changed the title
Collaborator
|
Thanks for your work! CI seems to fail to build. Could you please update your PR to resolve build issues (see https://github.com/polymorphicshade/Tubular/actions/runs/14768893598/job/41465425286?pr=222) (probably nothing related to functionality but obeying the checkstyle rules will keep project organized, thanks in advance 🤗) |
Contributor
Author
|
Should fix check style issues. Will need to update extractor for ci to succeed though (after extractor changes are merged?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, multiple segments appear one after another, causing the player to skip one, and play the video for half a second before skipping the second. Now, "chained" segments like this are skipped together, instead of individually
Requires Extractor change polymorphicshade/TubularExtractor#23